wasm middleware: change path property to url #3359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
bad link for AWS fixed here #3360 |
2 tasks
|
actually real link fix that needs to go to v1.11 is 3356, already in v1.10 |
This changes the configuration item for the Wasm binary from path to url. In doing so, we ease migration from other sources including HTTP and OCI. Signed-off-by: Adrian Cole <adrian@tetrate.io>
|
rebased |
codefromthecrypt
pushed a commit
to codefromthecrypt/dapr
that referenced
this pull request
May 3, 2023
Latest components-contrib changes the configuration of the Wasm binary from the property `path` to `url`. For example, if it was `bin/rewrite.wasm`, it is now `file://bin/rewrite.wasm`. The documentation updates are here: * dapr/docs#3359 * dapr/docs#3362 Signed-off-by: Adrian Cole <adrian@tetrate.io>
6 tasks
hhunter-ms
requested changes
May 3, 2023
daprdocs/content/en/reference/components-reference/supported-middleware/middleware-wasm.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-middleware/middleware-wasm.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-middleware/middleware-wasm.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-middleware/middleware-wasm.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-middleware/middleware-wasm.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-middleware/middleware-wasm.md
Outdated
Show resolved
Hide resolved
…iddleware/middleware-wasm.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: Crypt Keeper <64215+codefromthecrypt@users.noreply.github.com>
…iddleware/middleware-wasm.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: Crypt Keeper <64215+codefromthecrypt@users.noreply.github.com>
…iddleware/middleware-wasm.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: Crypt Keeper <64215+codefromthecrypt@users.noreply.github.com>
…iddleware/middleware-wasm.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: Crypt Keeper <64215+codefromthecrypt@users.noreply.github.com>
…iddleware/middleware-wasm.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: Crypt Keeper <64215+codefromthecrypt@users.noreply.github.com>
…iddleware/middleware-wasm.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: Crypt Keeper <64215+codefromthecrypt@users.noreply.github.com>
|
Thanks again @hhunter-ms! |
|
Stale PR, paging all reviewers |
|
@codefromthecrypt - You will need to perform a new pull on Dapr v1.11 branch for the build to succeed. Thx |
hhunter-ms
approved these changes
May 9, 2023
|
thanks again @hhunter-ms and @msfussell! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
This changes the configuration item for the Wasm binary from path to
url. In doing so, we ease migration from other sources including HTTP
and OCI.
Issue reference
dapr/components-contrib#2817 - change that results in this update
dapr/components-contrib#2700 - the change enables this issue to complete in 1.12